Adding JwtBuilder #140

paule96 · 2017-10-31T19:03:00Z

Start the work on a fluent-API to decode und create a JWT.

…es/138

Main changes in the validation method. This now works with the new JwtParts too Enum Name change from JwtParts to JwtPartsPointer. Today the last commit.

abatishchev · 2017-10-31T19:18:01Z

src/JWT/JWT.csproj

@@ -43,5 +43,8 @@

  <ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.3'">
    <PackageReference Include="System.Security.Cryptography.Csp" Version="4.3.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.5.0-preview-20170810-02" />


Do you know why both MsTest and xUnit are here?

oh sorry. that was a test, to get the test runing. I remove this.

abatishchev · 2017-10-31T19:18:47Z

src/JWT/JWTBuilder/Builder.cs

+    /// <summary>
+    /// Build an Decode JWT for with a Fluent-API.
+    /// </summary>
+    public class Builder


I'd call it JwtBuilder withing main JWT project since it so far doesn't add new dependencies

The reflection stuff is new. This is why I upgrade to .net standard 2.0.

So you think we don't need the sub-namespace?

I'd not have sub-namespaces until there are too many classes in the root or there is a strict need such as grouping/separation

abatishchev · 2017-10-31T19:19:24Z

src/JWT/JWTBuilder/Builder.cs

+        /// Check if we have enaught information to build a new Token.
+        /// </summary>
+        /// <returns>Returns true if all requierd information are there to create a token.</returns>
+        private bool canWeBuild()


CanBuild()

abatishchev · 2017-10-31T19:19:34Z

src/JWT/JWTBuilder/Builder.cs

+        /// Check if we have enaught informations to decode a token.
+        /// </summary>
+        /// <returns>Returns ture if all requiered informations are there to create a token.</returns>
+        private bool canWeDecode()


CanDecode()

abatishchev · 2017-10-31T19:20:28Z

src/JWT/JWTBuilder/Builder.cs

+            urlEncoder != null
+            )
+            {
+                if (verify && secret == null && secret.Length > 0)


return (!verify || (verify && secret == null && secret.Length > 0);

abatishchev · 2017-10-31T19:21:18Z

src/JWT/JWTBuilder/Enums/HeaderNames.cs

+    /// All predefined Headers specified by RFC. (https://tools.ietf.org/html/rfc7519)
+    /// Last update 31.10.2017
+    /// </summary>
+    public enum HeaderNames


HeaderName (singular)

abatishchev · 2017-10-31T19:22:06Z

src/JWT/JWTBuilder/Helper/EnumHelper.cs

+        /// </summary>
+        /// <param name="value">A object that have the Describtion Attribut set</param>
+        /// <returns>The string of the Describtion</returns>
+        private static string getValueOfDescription(object value)


GetValueOfDescription (CamelCase)

abatishchev · 2017-10-31T19:22:33Z

src/JWT/JWTBuilder/Helper/EnumHelper.cs

+        private static string getValueOfDescription(object value)
+        {
+            var info = value.GetType().GetField(value.ToString());
+            var attributes = (DescriptionAttribute[])info.GetCustomAttributes(typeof(DescriptionAttribute), false);


There is extension method GetCustomAttribute<DescriptionAttribute>()

abatishchev · 2017-10-31T19:23:07Z

src/JWT/JWTBuilder/Models/JWTData.cs

+        /// </summary>
+        /// <param name="Header">A Instance of a dictionary that contains the headers</param>
+        /// <param name="PayLoad">A instance of a dictionary that contans the payload</param>
+        public JWTData(Dictionary<string, string> Header, Dictionary<string, object> PayLoad)


We already have class for this - JwtParts. You can reuse it once merge the projects

Hi @abatishchev I don't know if I can reuse it. I don't think this to classes represent the same stuff.

JWParts are more a think to make the work with a encoded token easier. But JWTDate is more for the decoded Token work. So you can easy add an remove data from the token befor you encode the token.
I'm not shure if I can merge this two worlds together.

Because to get a JWTData from a JWTParts you need for example a URLDecoder.

abatishchev · 2017-10-31T19:23:34Z

src/JWT/JWTBuilder/Models/JWTData.cs

+        /// Create a new instance of JWTData and initalize Header and Payload.
+        /// </summary>
+        /// <returns>A Instance of <see cref"JWTData"/></returns>
+        public JWTData() : this(Header: new Dictionary<string, string>(), PayLoad: new Dictionary<string, object>())


Parameters should be camelCase'd

…6/jwt into issues/113_PayLoadBuilder

paule96 · 2017-10-31T20:28:03Z

I think currently about the Extensions folder to put all the Builder-API-Methods as extension methods in separate classes, so that the builder class don't explode. What do you think about this?

…6/jwt into issues/113_PayLoadBuilder

paule96 · 2017-11-05T14:46:49Z

I have start the work to the extension methods. Please take a look at this.

nbarbettini · 2017-12-13T03:40:56Z

Approving so I don't block the merge later. Looking good @paule96! This adds something I've wanted in JWT.NET for a long time. 😄

I left a number of comments with small nitpicks like typos, etc. I think the library should use DateTimeOffset instead of DateTime, but that might be a larger discussion.

Cheers!

abatishchev · 2017-12-13T18:43:32Z

@nbarbettini thanks a lot! You've spotted many silly errors. Made me scan the codebase once again, fix all of them, find some more. Your helps as always is appreciated :)

…6/jwt into issues/113_PayLoadBuilder

abatishchev · 2017-12-13T20:08:07Z

Wow, we did it. Big thanks to @paule96 for your contribution!

abatishchev · 2017-12-13T20:14:25Z

Pushed to NuGet as 3.2.0-beta

paule96 · 2017-12-14T20:35:49Z

Hey developers,

I'm happy to see this code now in the main repo! Thanks to all your feedback. 👍
@abatishchev @nbarbettini

Paul Jeschke and others added 13 commits October 29, 2017 16:41

Add overloads without the JWT secret. And do some clean code stuff.

f99c464

Merge branch 'master' into issues/138

4b786e4

react to the comments of the pullrequest.

56d7aa3

react to the comments of the pullrequest.

9a80a1d

Merge branch 'issues/138' of https://github.com/paule96/jwt into issu…

9e4bc8f

…es/138

resolved the second wave of pr-comments :)

0419fe1

Main changes in the validation method. This now works with the new JwtParts too Enum Name change from JwtParts to JwtPartsPointer. Today the last commit.

fix a typo. I have use the payload a signature. Bad bug

3ccf1a5

Updating xml doc

5264ae2

Bumping nuget version to 3.1.0

fdc44a9

Updating xml docs

0c9a93f

Minor refactoring/tweaks

a1bfb33

Adding xml doc

eb38514

add the builder.

87ceeca

paule96 mentioned this pull request Oct 31, 2017

Payload Builder #113

Closed

paule96 added 3 commits October 31, 2017 20:07

add the builder.

72f33cc

merge with latest changes

ce1e51b

Merge branch 'master' into issues/113_PayLoadBuilder

0f6ba81

abatishchev changed the title ~~Start working on #113~~ Adding JwtBuilder Oct 31, 2017

abatishchev requested changes Oct 31, 2017

View reviewed changes

paule96 added 3 commits October 31, 2017 21:20

same change to pull request comments

555f155

Merge branch 'issues/113_PayLoadBuilder' of https://github.com/paule9…

e161e73

…6/jwt into issues/113_PayLoadBuilder

rename headerName file too

94c603e

paule96 added 6 commits November 4, 2017 13:56

add tests and fix some bugs.

c7a5d86

change docu. So the examples now use the JWTBuilder

410d4e9

better test

84fc8c2

Merge branch 'master' into issues/113_PayLoadBuilder

87dc64b

Add ExtensionsMethods to the builder

890bf9c

Merge branch 'issues/113_PayLoadBuilder' of https://github.com/paule9…

7f78cb4

…6/jwt into issues/113_PayLoadBuilder

abatishchev added 5 commits December 13, 2017 09:52

Renaming, moving JwtData

b38d4bb

Moving all classes to Builder folder but internals

e63c1cf

Renaming, refactoring

5d9e484

Fixing target framework condition

abdadad

Reformatting the file

dc104b5

abatishchev mentioned this pull request Dec 13, 2017

DateTimeOffset should be used rather than DateTime #145

Closed

Updating, fixing tests

a8af327

abatishchev approved these changes Dec 13, 2017

View reviewed changes

abatishchev added 6 commits December 13, 2017 10:57

Updating xml doc

08980f5

Updating readme

57bb799

Updating readme

49241cf

Merge

54c4d72

Renaming JwtBuilderExtensions. Adding DateTimeExtensions

31b5bf5

Updating readme

a6be016

abatishchev approved these changes Dec 13, 2017

View reviewed changes

abatishchev added 9 commits December 13, 2017 11:25

Fixing csproj

de77dc3

Moving JwtBuilder to Builder folder

e3a7638

Targeting .net std 1.3 by tests.common

2272379

Fixing typo

5b3d355

Updating exceptions

753c95f

Moving stuff to subfolders

cadf8ee

Moving stuff to subfolders

b8f4dac

Merge branch 'issues/113_PayLoadBuilder' of https://github.com/paule9…

0260f3f

…6/jwt into issues/113_PayLoadBuilder

Adding xml doc

2f97f87

abatishchev merged commit 3e62ccd into jwt-dotnet:master Dec 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding JwtBuilder #140

Adding JwtBuilder #140

paule96 commented Oct 31, 2017

abatishchev Oct 31, 2017

paule96 Oct 31, 2017

paule96 Oct 31, 2017

abatishchev Oct 31, 2017

paule96 Oct 31, 2017

paule96 Oct 31, 2017

abatishchev Oct 31, 2017

abatishchev Oct 31, 2017

paule96 Oct 31, 2017

abatishchev Oct 31, 2017

paule96 Oct 31, 2017

abatishchev Oct 31, 2017

paule96 Oct 31, 2017

abatishchev Oct 31, 2017

paule96 Oct 31, 2017

abatishchev Oct 31, 2017

paule96 Oct 31, 2017

abatishchev Oct 31, 2017

paule96 Oct 31, 2017

abatishchev Oct 31, 2017

paule96 Nov 5, 2017

abatishchev Oct 31, 2017

paule96 Oct 31, 2017

paule96 commented Oct 31, 2017 •

edited by abatishchev

Loading

paule96 commented Nov 5, 2017

nbarbettini commented Dec 13, 2017

abatishchev commented Dec 13, 2017

abatishchev commented Dec 13, 2017

abatishchev commented Dec 13, 2017 •

edited

Loading

paule96 commented Dec 14, 2017

Adding JwtBuilder #140

Adding JwtBuilder #140

Conversation

paule96 commented Oct 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paule96 commented Oct 31, 2017 • edited by abatishchev Loading

paule96 commented Nov 5, 2017

nbarbettini commented Dec 13, 2017

abatishchev commented Dec 13, 2017

abatishchev commented Dec 13, 2017

abatishchev commented Dec 13, 2017 • edited Loading

paule96 commented Dec 14, 2017

paule96 commented Oct 31, 2017 •

edited by abatishchev

Loading

abatishchev commented Dec 13, 2017 •

edited

Loading