Using single overload of WithSecret() but with params #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abatishchev
commented
Mar 23, 2018
•
abatishchev
commented
- Adding NuGet.config
- Removing, updating packages
- Using single overload of WithSecret() but with params
- Bumping nuget version
abatishchev
force-pushed
the
alex/secrets-2
branch
from
f623880 to
78154b3
Compare
abatishchev
force-pushed
the
alex/secrets-2
branch
from
528f0f1 to
e54a549
Compare
abatishchev
commented
Mar 23, 2018
| /// </remarks> | ||
| /// <returns>Current builder instance</returns> | ||
| public JwtBuilder WithSecrets(string[] secrets) | ||
| public JwtBuilder WithSecret(params string[] secrets) |
There was a problem hiding this comment.
@codingmate what would you say?
There was a problem hiding this comment.
Way better.
How did I miss that, duh 😃
abelsayed
approved these changes
Mar 23, 2018
abatishchev
added a commit
that referenced
this pull request
Mar 23, 2018
* Adding NuGet.config * Removing, updating packages * Using single overload of WithSecret() but with params * Bumping nuget version
|
Pushed to NuGet as 5.0.0-beta2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.