Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the RS256Algorithm to take in the RSA Service Provider/RSA #195

Merged
merged 5 commits into from
May 5, 2019
Merged

Change the RS256Algorithm to take in the RSA Service Provider/RSA #195

merged 5 commits into from
May 5, 2019

Conversation

glennawatson
Copy link
Contributor

This fixes #164

This changes the RS256Algorithm class not to directly take in a Certificate but instead get the RSA/RSACryptoServiceProvider combination.

this is helpful in scenarios such as AWS Cognitio where they provide the modulo and exponent directly.

@abatishchev
Copy link
Member

Thanks so much for contributing this change!
The only thing, beside the comments I left above, please bump the version. At least the minor. Or the major, if it's a breaking change, and it might be.

@abatishchev abatishchev self-assigned this May 5, 2019
@abatishchev abatishchev added this to the 5.0 milestone May 5, 2019
@abatishchev
Copy link
Member

Argh! I'm not a pro user of GitHub reviews so messed it up. Can't see half of my own comments.

@glennawatson
Copy link
Contributor Author

Argh! I'm not a pro user of GitHub reviews so messed it up. Can't see half of my own comments.

You can click on the "Show Resolved" button in the right hand side and i'll come up.

@abatishchev
Copy link
Member

If only I could figure out why gated build isn't getting kicked off...

@abatishchev
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@abatishchev
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@glennawatson
Copy link
Contributor Author

I am on a fork most likely. Azure DevOps tends to be security concious of external forks to avoid man in the middle attacks.

@abatishchev
Copy link
Member

Yeap, I allow the build to run on forks. Re-invoking it via the command apparently worked. And it has succeeded.

So what would you say? Good to go?

@glennawatson
Copy link
Contributor Author

Go for it.

@abatishchev abatishchev merged commit f9a56eb into jwt-dotnet:master May 5, 2019
@abatishchev
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

RS256 implemention not having to rely on X509 certificate
2 participants