-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the RS256Algorithm to take in the RSA Service Provider/RSA #195
Conversation
Thanks so much for contributing this change! |
Argh! I'm not a pro user of GitHub reviews so messed it up. Can't see half of my own comments. |
You can click on the "Show Resolved" button in the right hand side and i'll come up. |
If only I could figure out why gated build isn't getting kicked off... |
/AzurePipelines run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/AzurePipelines run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
I am on a fork most likely. Azure DevOps tends to be security concious of external forks to avoid man in the middle attacks. |
Yeap, I allow the build to run on forks. Re-invoking it via the command apparently worked. And it has succeeded. So what would you say? Good to go? |
Go for it. |
Done via https://abatishchev.visualstudio.com/Jwt.Net/_releaseProgress?_a=release-pipeline-progress&releaseId=11. See https://www.nuget.org/packages/JWT/5.1.0 (should appear soon) |
This fixes #164
This changes the RS256Algorithm class not to directly take in a Certificate but instead get the RSA/RSACryptoServiceProvider combination.
this is helpful in scenarios such as AWS Cognitio where they provide the modulo and exponent directly.