Cleanup unit tests

[pBouillon]

Goal

How

I refactored most of the tests to normalize their redaction. Using the standard AAA testing and two tools to simplify them as much as possible.

In practice

Fluent Assertions

I used FluentAssertions, most of the tests are now way more readables and may surely allow newcomers to understand better and faster how to understand the underlying logic.

For example:

// From this test case:
Assert.True(token.Length > 0 && token.Split('.').Length == 3);

// To this one:
tokenBuilt.Should()
     .NotBeEmpty("because the token should contains some data");

tokenBuilt.Split('.').Should()
     .HaveCount(3, "because the built token should have the three standard parts");

AutoFixture

https://github.com/AutoFixture/AutoFixture is a tool that allow us to specify a data type that we are going to use, without having to handle its initialization and writting magic data. It also bring more randomness in the unit tests and allow us to have a behaviour less predictable.

With this package, we can be focused only on the data we are working with and that matter for the test case.

For example:

// From this test case:
    .WithSecret("fjhsdghflghlk")

// To this one:
var secret = _fixture.Create<string>();
// ...
    .WithSecret(secret)

[abatishchev]

Thank you so much! I'm always using AAA and FA in tests myself, and often use AF too. Tests in this project needed more love for a long time.

The only change I'm not sure about is the downgrade from net462 to net461.

[abatishchev]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[pBouillon]

What is this failure @abatishchev ? 🤔

[abatishchev]

I think the latest is net472, not 473. Can you please try that one? It should succeed then and I'll merge right away

[pBouillon]

Done !

[abatishchev]

Yay, thank you again!

[pBouillon]

You're welcome ! Hope I can help in a near future !

[abatishchev]

If you'd like to contribute more, please help to convert the project with the .NET Framework version of tests to PackageReference/SDK-based, one of the item @glennawatson has planned to do in #211.

Another option is to get rid off then altogether as I'm not quite sure they bring much value.

What both of you think about this?

[pBouillon]

I'm not very familiar with this but I would be glad to help !
Could you open an issue with more details so I can search a little how to do it ?

[glennawatson]

The work has already been done just needs to separated into a separate pr

[glennawatson]

https://github.com/jwt-dotnet/jwt/blob/84b4108d673b93eaee1aa5220fab14e2ff469d9f/tests/JWT.Tests.NETFramework/JWT.Tests.NETFramework.csproj is the file. Also delete the packages.config file

[pBouillon]

I'll give it a look whenever I can