Moving Base64UrlEncode/Base64UrlDecode to separate entity #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abatishchev
commented
Apr 3, 2017
•
abatishchev
commented
- Adding IBase64UrlEncoder implemented by JwtBase64UrlEncoder. Calling it from JsonWebToken.Base64UrlEncode/Base64UrlDecode.
- Updating tests
…it from JsonWebToken.Base64UrlEncode/Base64UrlDecode.
|
I'll wait CI/CD to run tests automatically first |
…it from JsonWebToken.Base64UrlEncode/Base64UrlDecode.
abatishchev
force-pushed
the
url-base64-encode
branch
from
ab06087 to
6a3a343
Compare
abatishchev
force-pushed
the
url-base64-encode
branch
from
6a3a343 to
cc06084
Compare
nbarbettini
reviewed
Apr 7, 2017
package.cmd
Outdated
| if not exist package\lib\net35 mkdir package\lib\net35 | ||
|
|
||
| msbuild src\JWT.sln -p:Configuration=Release | ||
| copy src\JWT\bin\Release\JWT.dll package\lib\net35 |
There was a problem hiding this comment.
Looks like some extra changes got moved into this PR?
src/JWT/IBase64UrlEncoder.cs
Outdated
| { | ||
| public interface IBase64UrlEncoder | ||
| { | ||
| string UrlEncode(byte[] input); |
There was a problem hiding this comment.
Seems a bit redundant to have Url twice, perhaps the method could just be Encode and Decode?
There was a problem hiding this comment.
Yeah, was thinking about this too. Dropped the prefix.
Removing Encode prefix from IBase64UrlEncoder
abatishchev
force-pushed
the
url-base64-encode
branch
from
471188f to
b650afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.