Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Json.Net to v10, other dev/test dependencies #83

Merged
merged 3 commits into from
Apr 10, 2017
Merged

Conversation

abatishchev
Copy link
Member

@abatishchev abatishchev commented Apr 8, 2017

Based on #75 discussion.

The most important change: removed the beta prefix.

@abatishchev abatishchev mentioned this pull request Apr 8, 2017
@abatishchev abatishchev self-assigned this Apr 8, 2017
@abatishchev abatishchev requested a review from nbarbettini April 8, 2017 04:20
@abatishchev abatishchev added this to the 2.0 milestone Apr 8, 2017
@nbarbettini
Copy link
Contributor

LGTM 👍

@abatishchev abatishchev merged commit dd35710 into master Apr 10, 2017
@abatishchev abatishchev deleted the json10 branch April 10, 2017 22:13
@ericbock
Copy link

It seems like the .nuspec in v2 needs to be updated to account for the newer version of Json.Net. If I use any version of Json.Net prior to 10.0.1 I get: Could not load file or assembly 'Newtonsoft.Json, Version=10.0.0.0

@abatishchev
Copy link
Member Author

abatishchev commented Jun 12, 2017

Hi, Versions of Jon.Net from 6x till 10.x are binary backward compatible. So I don't think we need to update the nuspec. Instead please try to add assembly binding redirect into your Web/App.config, e.g. from version 0.0.0.0 till 10.0.0.0 to your version, i.e. 6.0.0.0 or 10.0.0.0, etc.

@ericbock
Copy link

That worked, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants