Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify AppVeyor build image #92

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

nbarbettini
Copy link
Contributor

Minor fix: I forgot to include this in the original commit of the AppVeyor config. This will pin the AppVeyor build environment to Visual Studio 2017 (which is confirmed working), and will remove the requirement of picking this when setting up AppVeyor.

@nbarbettini nbarbettini requested a review from abatishchev April 26, 2017 23:25
@nbarbettini nbarbettini mentioned this pull request Apr 26, 2017
2 tasks
@abatishchev abatishchev added this to the 3.0 milestone Apr 26, 2017
@nbarbettini nbarbettini merged commit 43881f0 into master Apr 26, 2017
@nbarbettini nbarbettini deleted the update-appveyor-config branch April 26, 2017 23:27
@abatishchev
Copy link
Member

abatishchev commented Apr 26, 2017

https://ci.appveyor.com/project/abatishchev/jwt

194 Build success

Awesome!

Can I ask now to work on NuGet publish once you have some extra time, please?

@abatishchev
Copy link
Member

Oh, it says version is 1.0.3. Should I specify it in the settings or there a way to do this in appveyor.yml?

@nbarbettini
Copy link
Contributor Author

Yep, I saw it ran the checks for this PR! 🎉

Will open a new issue to discuss NuGet push.

@nbarbettini
Copy link
Contributor Author

Oh, it says version is 1.0.3. Should I specify it in the settings or there a way to do this in appveyor.yml?

The build version number is autoincrementing, I usually ignore it. The NuGet package version is untouched (see the Artifacts tab).

@abatishchev
Copy link
Member

I'd keep them in-sync to avoid confusion similar to mine. Or just put 0.0.{build}, that's what I did, let's how it will go. Thanks again!

@nbarbettini
Copy link
Contributor Author

FWIW, the AppVeyor "version" doesn't show up anywhere except at the top of the build log. Otherwise, it gets thrown away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants