change to signature of JWT.decode method

[rwygand]

JWT.decode can now, since the inclusion of MultiJson, raise a MultiJson::Decode error from lines 67 and 68. This means that he method signature of decode has changed to raise both JWT::DecodeError and MultiJson::DecodeError. Was this change intentional? It's breaking some test cases of mine that expect a JWT::DecodeError to be raised.

[progrium]

I don't believe it's intentional. I assume you'd expect the
MultiJson::DecodeError to be caught and re-raised as JWT::DecodeError? That
sounds fine to me if you want to patch.

On Tue, Feb 12, 2013 at 10:02 AM, Rob Wygand notifications@github.comwrote:

JWT.decode can now, since the inclusion of MultiJson, raise a
MultiJson::Decode error from lines 67 and 68. This means that he method
signature of decode has changed to raise both JWT::DecodeError and
MultiJson::DecodeError. Was this change intentional? It's breaking some
test cases of mine that expect a JWT::DecodeError to be raised.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/14.

Jeff Lindsay
http://progrium.com

[rwygand]

Yeah, that's what I figured... I just wanted to be sure of intent. I'll
submit a patch ASAP.

On Tue, Feb 12, 2013 at 12:26 PM, Jeff Lindsay notifications@github.comwrote:

I don't believe it's intentional. I assume you'd expect the
MultiJson::DecodeError to be caught and re-raised as JWT::DecodeError?
That
sounds fine to me if you want to patch.

On Tue, Feb 12, 2013 at 10:02 AM, Rob Wygand notifications@github.comwrote:

JWT.decode can now, since the inclusion of MultiJson, raise a
MultiJson::Decode error from lines 67 and 68. This means that he method
signature of decode has changed to raise both JWT::DecodeError and
MultiJson::DecodeError. Was this change intentional? It's breaking some
test cases of mine that expect a JWT::DecodeError to be raised.

—
Reply to this email directly or view it on GitHub<
https://github.com/progrium/ruby-jwt/issues/14>.

Jeff Lindsay
http://progrium.com

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/14#issuecomment-13455314.

[progrium]

Did you submit a patch for this?

[rwygand]

Yes, and it was merged: #16

[progrium]

Cool.