Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General purpose heap #2

Open
pelikhan opened this issue Apr 26, 2020 · 4 comments
Open

General purpose heap #2

pelikhan opened this issue Apr 26, 2020 · 4 comments

Comments

@pelikhan
Copy link

Since this is not specific to arcade, we should make sure this data structure works in microbit too. Maybe rename to

pxt-heap

@jwunderl
Copy link
Owner

I put the heap into https://github.com/jwunderl/pxt-heap already actually, which in theory should work across the board (probably have to add to readme.md for search to pick it put though?). This repo's specific to arcade at the moment as it's based around tilemap.

@pelikhan
Copy link
Author

You can move arcade specific dependencies to "testDependencies"

@jwunderl
Copy link
Owner

jwunderl commented Apr 27, 2020

Hm, it's definitely non trivial to make a package usable by multiple targets at the moment; "testDependencies" only works if the main package compiles without the "testDependencies", so you also have to include at least the package that contains the builtin types ("core"); I'm assuming this is fine across the board as everything probably has a core dep, but it makes it awkward and reimporting the extension didn't work till after you manually delete the old copy. Anyway, as far as I can tell it works in beta microbit now (won't work in live as there are a few language features like array unpacking that haven't made it there yet).

Ideally we could probably just have a checkbox or something for most of the targets, and use that to build pxt json - e.g. we know if we're going to work on both arcade and microbit we need to add it to the list of supportedEditors, downgrade device to core (probably?) in deps, and add any target specific repos to testDeps

@pelikhan
Copy link
Author

pelikhan commented Apr 27, 2020 via email

@darzu darzu changed the title General purpose General purpose heap May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants