This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Allow async storage for cache provider #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveols
suggested changes
Jun 25, 2018
src/context.js
Outdated
| if (cacheProvider && cacheProvider.get) { | ||
| const cacheResponse = cacheProvider.get(cacheKey); | ||
| if (cacheResponse instanceof Promise) { | ||
| return cacheResponse.then(cachedData => setState({ cachedData, hasLoaded: true })); |
There was a problem hiding this comment.
If the provided promise is rejected then setState never gets called here, leading hasLoaded to stay false and nothing gets rendered (deadlocked?).
daveols
reviewed
Jun 25, 2018
src/context.js
Outdated
| @@ -77,7 +80,10 @@ class LoadsConsumer extends React.Component<ConsumerProps> { | |||
| if (cacheProvider && cacheProvider.get) { | |||
| const cacheResponse = cacheProvider.get(cacheKey); | |||
| if (cacheResponse instanceof Promise) { | |||
There was a problem hiding this comment.
This needs to be more generic to detect 3rd party promise implementations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
getandsetfunctions in thecacheProviderto be async (return a promise).