Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance landing page Responsiveness #151

Closed
mathanraj0601 opened this issue Oct 2, 2023 · 13 comments · Fixed by #152
Closed

Enhance landing page Responsiveness #151

mathanraj0601 opened this issue Oct 2, 2023 · 13 comments · Fixed by #152
Assignees
Labels

Comments

@mathanraj0601
Copy link
Contributor

Enhance responsiveness

I found that the text and description in the card of the landing page are text-aligned left for

  • JSON Schema Viewer / Editor
  • Configurable
  • Open source
    I think It does not suit the responsiveness of the website
    I went through the code and made it text-align center below I will attach the screenshot comparing both:

Screen Width above 1200 px

From:

as1

To;

ss1

Screen Width below 1200 px

From:

as2

To:

ss2

Screen Width below 500px:

###From:

as3
###To:

ss3

@mathanraj0601
Copy link
Contributor Author

If you like the above suggestion let me know and l like to contribute to this project : )

@jy95
Copy link
Owner

jy95 commented Oct 2, 2023

@mathanraj0601 You are welcome ;)

@jy95 jy95 added the hacktoberfest hacktoberfest label Oct 2, 2023
@mathanraj0601
Copy link
Contributor Author

That's Great! @jy95 Can you assign me so that i can start my work: )

@mathanraj0601
Copy link
Contributor Author

I can't find the local setup instructions for project can you share the setup instructions or command to start the project locally

  • i have done with npm install
  • i can't find a script for npm start

@jy95
Copy link
Owner

jy95 commented Oct 2, 2023

@mathanraj0601 To build the website, you can apply same logic I did for the Github actions script

// Install lib 💻
npm install
// Build lib 🤖
npm run build
// Link lib 🔗
npm link
// Install website 💻
cd testsite
npm link docusaurus-json-schema-plugin --save
npm install --prefer-dedupe 
npm dedupe  

By doing a npm start in the testsite folder, you will be able to see a local version of the website.
As you can see, when you will create the MR ( such as #150 ), you will have a preview website as well

@mathanraj0601
Copy link
Contributor Author

Thank you @jy95 !!

@jy95 jy95 closed this as completed in #152 Oct 2, 2023
jy95 added a commit that referenced this issue Oct 2, 2023
Fixes : #151 Enhance landing page Responsiveness
@mathanraj0601
Copy link
Contributor Author

Can i create a new issue to add the step involved in contribution.MD to setup the application locally following the step you mentioned?

@jy95
Copy link
Owner

jy95 commented Oct 2, 2023

@mathanraj0601 If you want. It might be better to put them in the readme of the testsite no ? (as people reads more readme.MD usually)

https://github.com/jy95/docusaurus-json-schema-plugin/blob/main/testsite/README.md

@mathanraj0601
Copy link
Contributor Author

Yes !! @jy95

@mathanraj0601
Copy link
Contributor Author

mathanraj0601 commented Oct 2, 2023

I have taken a long time to notice the setup to set up the application locally.
Most of the projects put the development and other guides in the contribution itself. if possible can we add a simple section in the contribution.md as Development with the description " For development setup click here" with the link to that file ?

It's just a suggestion If not required the setup itself is okay : )

@jy95
Copy link
Owner

jy95 commented Oct 2, 2023

@mathanraj0601 What matter is that instructions are found somewhere (in contribution.md / readme.md).
Feel free to choose the one you think it is the best

@mathanraj0601
Copy link
Contributor Author

mathanraj0601 commented Oct 2, 2023

Okay, @jy95 I will check across many projects and see how they maintain the setup and choose the appropriate area to put setup instructions then contribute : )
Thank you !!

Copy link

github-actions bot commented Nov 1, 2023

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants