perf: simplify control flow

jy95 · May 1, 2024 · 2ca42dc · 2ca42dc
1 parent 64bfabc
commit 2ca42dc
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 20 deletions.
diff --git a/src/translators/dayOfWeek.ts b/src/translators/dayOfWeek.ts
@@ -23,16 +23,16 @@ export function transformDayOfWeekToText({
   // If empty, skip it
   if (dayOfWeek === undefined || dayOfWeek.length === 0) {
     return undefined;
-  } else {
-    // Turn it into a string
-    const dayOfWeeks = dayOfWeek.map((dayCode) =>
-      i18next.t(`daysOfWeek:${dayCode}`),
-    );
-    const dayOfWeeksAsString = fromListToString(i18next, dayOfWeeks);
-
-    return i18next.t("fields.dayOfWeek.dayOfWeek", {
-      count: dayOfWeek.length,
-      dayOfWeek: dayOfWeeksAsString,
-    });
   }
+
+  // Turn it into a string
+  const dayOfWeeks = dayOfWeek.map((dayCode) =>
+    i18next.t(`daysOfWeek:${dayCode}`),
+  );
+  const dayOfWeeksAsString = fromListToString(i18next, dayOfWeeks);
+
+  return i18next.t("fields.dayOfWeek.dayOfWeek", {
+    count: dayOfWeek.length,
+    dayOfWeek: dayOfWeeksAsString,
+  });
 }
diff --git a/src/translators/timeOfDay.ts b/src/translators/timeOfDay.ts
@@ -41,14 +41,14 @@ export function transformTimeOfDayToText({
   // If empty, skip it
   if (timeOfDay === undefined || timeOfDay.length === 0) {
     return undefined;
-  } else {
-    // Turn it into a string
-    const timeOfDays = timeOfDay.map(formatString);
-    const timeOfDaysAsString = fromListToString(i18next, timeOfDays);
-
-    return i18next.t("fields.timeOfDay", {
-      timeOfDay: timeOfDaysAsString,
-      count: timeOfDays.length,
-    });
   }
+
+  // Turn it into a string
+  const timeOfDays = timeOfDay.map(formatString);
+  const timeOfDaysAsString = fromListToString(i18next, timeOfDays);
+
+  return i18next.t("fields.timeOfDay", {
+    timeOfDay: timeOfDaysAsString,
+    count: timeOfDays.length,
+  });
 }