perf: undefinedChecks

jy95 · May 2, 2024 · 64381ee · 64381ee
1 parent eb93157
commit 64381ee
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/translators/countCountMax.ts b/src/translators/countCountMax.ts
@@ -3,6 +3,7 @@ import { extractTimingRepeat } from "../internal/extractTimingRepeat";
 import {
   isNotUndefined,
   noUndefinedInArray,
+  allUndefinedInArray,
 } from "../internal/undefinedChecks";
 
 // Types
@@ -24,7 +25,7 @@ export function transformCountCountMaxToText({
   let countMax = repeat.countMax;
 
   // Do nothing if no count, I am not a wizard
-  if (count === undefined && countMax === undefined) {
+  if (allUndefinedInArray(count, countMax)) {
     return undefined;
   }
 

diff --git a/src/translators/frequencyFrequencyMax.ts b/src/translators/frequencyFrequencyMax.ts
@@ -3,6 +3,7 @@ import { extractTimingRepeat } from "../internal/extractTimingRepeat";
 import {
   isNotUndefined,
   noUndefinedInArray,
+  allUndefinedInArray,
 } from "../internal/undefinedChecks";
 
 // Types
@@ -24,7 +25,7 @@ export function transformFrequencyFrequencyMaxToText({
   let max = repeat.frequencyMax;
 
   // Do nothing if no frequency / frequencyMax, I am not a wizard
-  if (frequency === undefined && max === undefined) {
+  if (allUndefinedInArray(frequency, max)) {
     return undefined;
   }
 

diff --git a/src/translators/offsetWhen.ts b/src/translators/offsetWhen.ts
@@ -2,6 +2,7 @@
 import { fromListToString } from "../utils/fromListToString";
 import { extractTimingRepeat } from "../internal/extractTimingRepeat";
 import { isArrayEmpty } from "../internal/isEmptyArray";
+import { isNotUndefined } from "../internal/undefinedChecks";
 
 // Types
 import type { DisplayOrderParams, I18N } from "../types";
@@ -46,7 +47,7 @@ function extractTime(minutes: number) {
 
 // Function to transform offset into a string
 function transformOffset(i18next: I18N, offset?: number): string | undefined {
-  if (offset === undefined || offset <= 0) {
+  if (!isNotUndefined(offset) || offset <= 0) {
     return undefined;
   }
 
@@ -93,7 +94,7 @@ export function transformOffsetWhenToText({
   let repeat = extractTimingRepeat(dos);
 
   // If empty, return undefined
-  if (repeat === undefined) {
+  if (!isNotUndefined(repeat)) {
     return undefined;
   }