Fix/types empty (#500)

* 🚧 UPDATE: add sp

* 🐛 FIX: type when there is no element in the Record (#499)

.changeset/tasty-scissors-call.md

@@ -0,0 +1,5 @@
+---
+'vite-plugin-kit-routes': patch
+---
+
+fix: type when there is no element in the Record

.prettierignore

@@ -16,4 +16,5 @@ $houdini
 $kitql
 stats.html
 
-db/
+db/
+ROUTES_*

packages/eslint-config-kitql/index.cjs

@@ -1,7 +1,12 @@
 module.exports = {
   root: true,
   parser: '@typescript-eslint/parser',
-  extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'prettier'],
+  extends: [
+    'eslint:recommended',
+    'plugin:@typescript-eslint/recommended',
+    'prettier',
+    'plugin:svelte/recommended',
+  ],
   plugins: ['unused-imports', 'svelte', '@typescript-eslint'],
   rules: {
     'no-console': ['error', { allow: ['info', 'warn', 'error', 'time', 'timeEnd'] }],
@@ -10,6 +15,7 @@ module.exports = {
     '@typescript-eslint/ban-ts-comment': 'off',
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-non-null-assertion': 'off',
+    '@typescript-eslint/ban-types': 'error',
   },
   overrides: [
     {

packages/vite-plugin-kit-routes/src/lib/ROUTES.ts

@@ -34,8 +34,14 @@ export const PAGES = {
   }) => {
     return `${params?.lang ? `/${params?.lang}` : ''}/match/${params.id}`
   },
-  lang_site: (params: { lang?: 'fr' | 'en' | 'hu' | 'at' | string; limit?: number } = {}) => {
-    return `${params?.lang ? `/${params?.lang}` : ''}/site${appendSp({ limit: params.limit })}`
+  lang_site: (
+    params: { lang?: 'fr' | 'en' | 'hu' | 'at' | string; limit?: number } = {},
+    sp?: Record<string, string | number>,
+  ) => {
+    return `${params?.lang ? `/${params?.lang}` : ''}/site${appendSp({
+      ...sp,
+      limit: params.limit,
+    })}`
   },
   lang_site_id: (
     params: { lang?: 'fr' | 'hu' | undefined; id?: string; limit?: number; demo?: string } = {},

packages/vite-plugin-kit-routes/src/lib/plugin.ts

@@ -591,6 +591,13 @@ const shouldLog = (kind: LogKind, options?: Options) => {
   return options.logs.includes(kind)
 }
 
+const arrayToRecord = (arr?: string[]) => {
+  if (arr && arr.length > 0) {
+    return `: { ${arr.join(', ')} }`
+  }
+  return `: Record<string, never>`
+}
+
 export const run = (options?: Options) => {
   let files = getFilesUnder(routes_path())
 
@@ -703,8 +710,8 @@ const appendSp = (sp?: Record<string, string | number | undefined>, prefix: '?'
 export type KIT_ROUTES = { 
 ${objTypes
   .map(c => {
-    return `  ${c.type}: { ${c.files
-      .map(d => {
+    return `  ${c.type}${arrayToRecord(
+      c.files.map(d => {
         return `'${d.keyToUse}': ${
           d.paramsFromPath.filter(e => e.fromPath === true).length === 0
             ? 'never'
@@ -715,15 +722,15 @@ ${objTypes
                 })
                 .join(' | ')
         }`
-      })
-      .join(', ')} }`
+      }),
+    )}`
   })
   .join('\n')}
-  Params: { ${[
+  Params${arrayToRecord([
     ...new Set(
       objTypes.flatMap(c => c.files.flatMap(d => d.paramsFromPath.map(e => `${e.name}: never`))),
     ),
-  ].join(', ')} }
+  ])}
 }
 `,
     ])

packages/vite-plugin-kit-routes/src/lib/plugins.spec.ts

@@ -223,7 +223,6 @@ describe('run()', () => {
           extra_search_params: 'with',
         },
         lang_site: {
-          // extra_search_params: 'with',
           explicit_search_params: { limit: { type: 'number' } },
           params: {
             // yop: { type: 'number' },
@@ -541,7 +540,6 @@ describe('run()', () => {
           extra_search_params: 'with',
         },
         lang_site: {
-          // extra_search_params: 'with',
           explicit_search_params: { limit: { type: 'number' } },
           params: {
             // yop: { type: 'number' },
@@ -705,7 +703,7 @@ describe('run()', () => {
     })
   })
 
-  it('with_ase', () => {
+  it('with path base', () => {
     const generated_file_path = 'src/test/ROUTES_test5.ts'
     run({
       generated_file_path,
@@ -723,7 +721,6 @@ describe('run()', () => {
           extra_search_params: 'with',
         },
         lang_site: {
-          // extra_search_params: 'with',
           explicit_search_params: { limit: { type: 'number' } },
           params: {
             // yop: { type: 'number' },

packages/vite-plugin-kit-routes/src/test/.gitignore

@@ -1 +1 @@
-ROUTES*
+ROUTES_*

packages/vite-plugin-kit-routes/vite.config.ts

@@ -26,7 +26,7 @@ export default defineConfig({
           },
         },
         lang_site: {
-          // extra_search_params: 'with',
+          extra_search_params: 'with',
           explicit_search_params: { limit: { type: 'number' } },
           params: {
             // yop: { type: 'number' },