Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate routes during build #588

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Generate routes during build #588

merged 4 commits into from
Jan 3, 2024

Conversation

fehnomenal
Copy link
Contributor

Rollup's buildStart gets called by pnpm dev and pnpm build, so it can be used to generate the routes file during build. And this allows to .gitignore it 🎉

I needed to call the post update command synchronously but I don't think this should be a problem?

jycouet
jycouet reviewed Jan 3, 2024
View reviewed changes
Copy link
Owner

@jycouet jycouet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for looking at this 🎉

packages/vite-plugin-kit-routes/src/lib/plugin.ts Outdated Show resolved Hide resolved
@fehnomenal fehnomenal requested a review from jycouet January 3, 2024 10:40
@jycouet jycouet merged commit 7d1f998 into jycouet:main Jan 3, 2024
4 checks passed
@jycouet
Copy link
Owner

jycouet commented Jan 3, 2024

Thx a lot 🎉

@github-actions github-actions bot mentioned this pull request Jan 3, 2024
Merged
@fehnomenal fehnomenal deleted the feat/build-routes branch January 6, 2024 23:30
@github-actions github-actions bot mentioned this pull request Nov 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycouet jycouet Awaiting requested review from jycouet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fehnomenal @jycouet