Skip to content

Commit

Permalink
green-code-initiative#63 fix: fixes metadata generation task from Son…
Browse files Browse the repository at this point in the history
…arSource/sonar-update-center-properties

Since "core" analyzers have been integrated more tightly with SonarQube, they no longer appear on the Marketplace. So now plugins should no longer explicitly "require" their respective language "core" analyzers.

More information: https://community.sonarsource.com/t/new-plugin-ecocode-requesting-inclusion-in-sonarqube-marketplace/85398/20
  • Loading branch information
jycr committed Apr 17, 2023
1 parent 08938f4 commit c62cd2d
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 12 deletions.
7 changes: 0 additions & 7 deletions java-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,6 @@
<version>3.11</version>
</dependency>

<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>31.0.1-jre</version>
</dependency>

<!-- for security on regex patterns : https://github.com/google/re2j -->
<dependency>
<groupId>com.google.re2j</groupId>
Expand Down Expand Up @@ -92,7 +86,6 @@
<!-- TODO : commented because plugin not loaded in SONAR if required version of java plugin is not installed -->
<!-- TODO : check how to resolve it (how to force this version in SonarQube installation) -->
<!-- <requirePlugins>java:${sonarjava.version}</requirePlugins> -->
<basePlugin>java</basePlugin>
<jreMinVersion>${java.version}</jreMinVersion>
</configuration>
</plugin>
Expand Down
1 change: 0 additions & 1 deletion javascript-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
<pluginClass>fr.greencodeinitiative.javascript.JavaScriptPlugin</pluginClass>
<sonarLintSupported>true</sonarLintSupported>
<sonarQubeMinVersion>${sonarqube.version}</sonarQubeMinVersion>
<basePlugin>javascript</basePlugin>
<jreMinVersion>${java.version}</jreMinVersion>
</configuration>
</plugin>
Expand Down
1 change: 0 additions & 1 deletion php-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
<pluginClass>fr.greencodeinitiative.php.PHPPlugin</pluginClass>
<sonarLintSupported>true</sonarLintSupported>
<sonarQubeMinVersion>${sonarqube.version}</sonarQubeMinVersion>
<basePlugin>php</basePlugin>
<jreMinVersion>${java.version}</jreMinVersion>
<requirePlugins>php:${sonarphp.version}</requirePlugins>
<sonarQubeMinVersion>${sonarqube.version}</sonarQubeMinVersion>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,10 @@
import java.io.InputStream;
import java.net.URL;
import java.nio.charset.StandardCharsets;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

import com.google.common.collect.ImmutableList;
import fr.greencodeinitiative.php.checks.AvoidDoubleQuoteCheck;
import fr.greencodeinitiative.php.checks.AvoidFullSQLRequestCheck;
import fr.greencodeinitiative.php.checks.AvoidSQLRequestInLoopCheck;
Expand Down Expand Up @@ -90,7 +88,7 @@ public String repositoryKey() {

@Override
public List<Class<?>> checkClasses() {
return ImmutableList.of(
return List.of(
AvoidDoubleQuoteCheck.class,
AvoidFullSQLRequestCheck.class,
AvoidSQLRequestInLoopCheck.class,
Expand Down

0 comments on commit c62cd2d

Please sign in to comment.