Skip to content

Commit

Permalink
Remove src/python/pants/bin:pants (pantsbuild#19688)
Browse files Browse the repository at this point in the history
I found this poking around. We don't want people doing `pip install
pantsbuild.pants`. Also it's completely superfluous because we have the
`python_distribution` with the `entry_point`. So double-whammy.
  • Loading branch information
thejcannon authored Aug 29, 2023
1 parent 4f13ae2 commit 7a292e4
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
2 changes: 1 addition & 1 deletion src/python/pants/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ python_distribution(
# N.B.: Must match [python] interpreter_constraints in pants.toml.
python_requires="==3.9.*",
),
entry_points={"console_scripts": {"pants": "src/python/pants/bin:pants"}},
entry_points={"console_scripts": {"pants": "pants.bin.pants_loader:main"}},
)

pex_binary(
Expand Down
11 changes: 0 additions & 11 deletions src/python/pants/bin/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -92,17 +92,6 @@ target(
],
)

# This binary's entry_point is used by the pantsbuild.pants sdist to setup a binary for
# pip installers, ie: it is why this works to get `pants` on your PATH:
# $ pip install pantsbuild.pants
# $ pants
pex_binary(
name="pants",
entry_point="pants.bin.pants_loader:main",
dependencies=[":pants_loader"],
strip_pex_env=False,
)

resources(
name="native_client",
sources=["native_client"],
Expand Down

0 comments on commit 7a292e4

Please sign in to comment.