Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

Remember whitespace for -E #356

Closed
jyn514 opened this issue Mar 26, 2020 · 0 comments · Fixed by #437
Closed

Remember whitespace for -E #356

jyn514 opened this issue Mar 26, 2020 · 0 comments · Fixed by #437
Labels
enhancement New feature or request lexer Issue dealing with parsing the lexical tokens of a program preprocessor Issue in the preprocessor (probably cycle detection) ui Helpful for user experience when seeing error or warnings

Comments

@jyn514
Copy link
Owner

jyn514 commented Mar 26, 2020

This would require adding a whitespace token to the lexer. This has a few advantages:

  • The output from -E would be much more readable
  • -E could be abused for non-C-like tokens (cc @Nemo157)
  • The preprocessor could be decoupled from the lexer, helping with Separate parsing into a library #266 (cc @pythondude325)
@jyn514 jyn514 added enhancement New feature or request lexer Issue dealing with parsing the lexical tokens of a program ui Helpful for user experience when seeing error or warnings preprocessor Issue in the preprocessor (probably cycle detection) labels Mar 26, 2020
This was referenced Mar 26, 2020
Open
Open
@hdamron17 hdamron17 mentioned this issue May 15, 2020
Merged
jyn514 added a commit that referenced this issue May 25, 2020
@jyn514
Merge pull request #437 from hdamron17/preprocessor-whitespace
ae5ac81 
Close #356 - Add whitespace token for preprocessor
@jyn514 jyn514 mentioned this issue Jun 12, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request lexer Issue dealing with parsing the lexical tokens of a program preprocessor Issue in the preprocessor (probably cycle detection) ui Helpful for user experience when seeing error or warnings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close #356 - Add whitespace token for preprocessor hdamron17/saltwater
1 participant
@jyn514