Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

Make git-testament optional and disable it by default #448

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

jyn514
Copy link
Owner

@jyn514 jyn514 commented May 23, 2020

This allows compiling rcc on alpine, which doesn't support proc-macros.
git-testament is mostly useful for debug builds anyways.

@jyn514
Copy link
Owner Author

jyn514 commented May 23, 2020

I just found that this doesn't help because thiserror-impl is a proc-macro, and we have a hard dependency on thiserror. This makes things tricky.

@jyn514
Copy link
Owner Author

jyn514 commented May 23, 2020

Status: rust-lang/rust#40174 (comment)

@jyn514
Copy link
Owner Author

jyn514 commented Jul 24, 2020

Going to merge this anyway since I think it's good to reduce compile times. I wish cargo had dev-dependencies for lib.rs :/

@jyn514 jyn514 force-pushed the git-testament-optional branch 2 times, most recently from 7713746 to 55badca Compare July 24, 2020 23:30
This allows compiling rcc on alpine, which doesn't support proc-macros.
git-testament is mostly useful for debug builds anyways.
@jyn514 jyn514 merged commit bf77377 into master Jul 24, 2020
@jyn514 jyn514 deleted the git-testament-optional branch July 24, 2020 23:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant