Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys.cleanup() in PythonInterpreter close() method closing thread pool _socket.NIO_GROUP in _socket.py #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sys.cleanup() in PythonInterpreter close() method closing thread pool _socket.NIO_GROUP in _socket.py #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Lib/_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,6 +1550,12 @@ def create_connection(address, timeout=_GLOBAL_DEFAULT_TIMEOUT,
for the socket to bind as a source address before making the connection.
An host of '' or port 0 tells the OS to use the default.
"""
# Added check to recreate thread pool if it is already shutdown
if NIO_GROUP.isShutdown():
log.debug("Theard pool is shutdown. Recreating...")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theard -> Thread

global NIO_GROUP
NIO_GROUP = NioEventLoopGroup(_NUM_THREADS, DaemonThreadFactory("Jython-Netty-Client-%s"))
sys.registerCloser(_shutdown_threadpool)

host, port = address
err = None
Expand Down