Stream input files instead of reading entire contents #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancez
force-pushed
the
stream_file_inputs
branch
3 times, most recently
from
9c28ef4 to
9c97587
Compare
jzelinskie
requested changes
Feb 14, 2019
added 2 commits
February 14, 2019 10:00
Currently these decoders are not using a streaming decoder so we read everything at once using ioutil.ReadAll, which means these do not return io.EOF as the faq code expects a decoder to return.
Also supports streaming input from stdin and removes the requirement for of passing any files to faq, defaulting to stdin if no file args are specified.
chancez
force-pushed
the
stream_file_inputs
branch
from
9c97587 to
e2167f1
Compare
|
Okay, I fixed the review comments and added back linguist detection. I rebased on top of #62 because I found a bug in decoding logic while handling this and wanted to fix that independently of this PR. |
jzelinskie
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also supports streaming input from stdin and removes the requirement for
of passing any files to faq, defaulting to stdin if no file args are
specified.
I removed the usage of linguist because it's not really helping and I felt my custom code to detect xml/yaml/json is sufficient, along with the existing filename extension based detection. We could continue to use linguist, but it would mean we need to read a lot more of the file's contents (maybe all of it?) and pass those contents to lingust, which makes things complicated since the bufio.Reader buffer is of limited length.