SAML2 logout feedback #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleftherias
commented
Feb 26, 2021
| } | ||
|
|
||
| @Bean |
There was a problem hiding this comment.
It seems like requestResolver() and requestResolver() don't need to be beans
| @@ -80,17 +80,16 @@ SecurityFilterChain web(HttpSecurity http, LogoutSuccessHandler successHandler, | |||
| redirect.onLogoutSuccess(request, response, authentication); | |||
| }) | |||
| ) | |||
| .addFilterAfter(new Saml2RelyingPartyInitiatedLogoutFilter(requestResolver), LogoutFilter.class); | |||
| .addFilterAfter(new Saml2RelyingPartyInitiatedLogoutFilter(requestResolver()), LogoutFilter.class); | |||
|
|
|||
| return http.build(); | |||
| } | |||
|
|
|||
| @Bean | |||
There was a problem hiding this comment.
It seems like the logoutSuccessHandler doesn't need to be a bean either.
| @@ -102,7 +102,8 @@ public OpenSamlLogoutRequestSpec resolveLogoutRequest(HttpServletRequest request | |||
| RelyingPartyRegistration registration, Authentication authentication) { | |||
| return new OpenSamlLogoutRequestSpec(registration) | |||
| .destination(registration.getAssertingPartyDetails().getSingleLogoutServiceLocation()) | |||
There was a problem hiding this comment.
Why do only destination, issuer and name have default values?
| @@ -102,7 +102,8 @@ public OpenSamlLogoutRequestSpec resolveLogoutRequest(HttpServletRequest request | |||
| RelyingPartyRegistration registration, Authentication authentication) { | |||
| return new OpenSamlLogoutRequestSpec(registration) | |||
| .destination(registration.getAssertingPartyDetails().getSingleLogoutServiceLocation()) | |||
| .issuer(registration.getEntityId()).name(authentication.getName()); | |||
| .issuer(registration.getEntityId()) | |||
| .name(authentication.getName()); | |||
| } | |||
|
|
|||
| public class OpenSamlLogoutRequestSpec implements Saml2LogoutRequestSpec<OpenSamlLogoutRequestSpec> { | |||
There was a problem hiding this comment.
Does it make sense to allow users to conveniently change the destination, issuer and name?
Is there a use case where they would want those values to be different than what they set up in the RelyingPartyRegistration?
jzheaux
force-pushed
the
saml2-logout
branch
7 times, most recently
from
a88c1b1 to
ddf8e7a
Compare
jzheaux
force-pushed
the
saml2-logout
branch
2 times, most recently
from
2ee9b25 to
f16548f
Compare
jzheaux
force-pushed
the
saml2-logout
branch
2 times, most recently
from
ebf88c5 to
2c6c988
Compare
jzheaux
force-pushed
the
saml2-logout
branch
6 times, most recently
from
d547bad to
86f6b95
Compare
jzheaux
force-pushed
the
saml2-logout
branch
2 times, most recently
from
4d82f8c to
6038bdb
Compare
jzheaux
force-pushed
the
saml2-logout
branch
3 times, most recently
from
25d7d4b to
a96844b
Compare
jzheaux
force-pushed
the
saml2-logout
branch
3 times, most recently
from
30bb291 to
4b29450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.