Skip to content

Commit

Permalink
Add shader module creation validation for features (gpuweb#4802)
Browse files Browse the repository at this point in the history
Validation of GPUShaderModule was missing the check that the
corresponding feature for each enable extension was enabled.
This requirement was listed in the features section only.
  • Loading branch information
alan-baker authored Aug 5, 2024
1 parent a189442 commit 7980a4b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions spec/index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -6622,6 +6622,9 @@ dictionary GPUShaderModuleDescriptor
<div class=validusage>
- |this| must not be [$invalid|lost$].
- |error| must not be a [=shader-creation error|shader-creation=] [=program error=].
- For each `enable` extension in |descriptor|.{{GPUShaderModuleDescriptor/code}},
the corresponding {{GPUFeatureName}} must be enabled
(see the [[#feature-index|Feature Index]]).
</div>

Note: [=Uncategorized errors=] cannot arise from shader module creation.
Expand Down

0 comments on commit 7980a4b

Please sign in to comment.