Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facing a problem while explore with other language #1

Closed
Arulmurugan-Sivapoosam opened this issue Feb 6, 2019 · 3 comments
Closed

Facing a problem while explore with other language #1

Arulmurugan-Sivapoosam opened this issue Feb 6, 2019 · 3 comments
Assignees
@k-lpmg
Labels
bug Something isn't working

Comments

@Arulmurugan-Sivapoosam
Copy link

Arulmurugan-Sivapoosam commented Feb 6, 2019 •
edited
Loading

When i explore with Tamil (SouthIndian language) as tagging suggestion then the tagging attribute is not applied for a whole word.

Solution:

taggingAttributeRange should be like this NSMakeRange(model.range.location+1, model.text.utf16.count).

need to get the characters count from utf16 encoding.

it'll be good if apply the same for updateAttributeText method's selectedLocation param (For cursor placing).

Refer the screenShots.

flaw
fix
@k-lpmg k-lpmg self-assigned this Feb 12, 2019
@k-lpmg k-lpmg added the bug Something isn't working label Feb 12, 2019
@k-lpmg
Copy link
Owner

k-lpmg commented Feb 12, 2019 •
edited
Loading

Thanks! @Arulmurugan-Sivapoosam
I will check and update soon.

k-lpmg added a commit that referenced this issue Feb 13, 2019
@k-lpmg
Fix string count issue (#1)
dc4c969
@k-lpmg
Copy link
Owner

k-lpmg commented Feb 13, 2019

Hi @Arulmurugan-Sivapoosam
I fix this issue and release 0.4.0 with support swift 4.2.
Thanks!

@k-lpmg k-lpmg closed this as completed Feb 13, 2019
@Arulmurugan-Sivapoosam
Copy link
Author

Hi @k-lpmg
Thanks for the update. will try with the new version.

lohenyumnam added a commit to lohenyumnam/Tagging that referenced this issue Mar 6, 2019
@lohenyumnam
k-lpmg#1 Added new protocol to tell user about the current possible t…
32d92e0 
…ag Text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k-lpmg k-lpmg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@k-lpmg @Arulmurugan-Sivapoosam