少しマシにした #1
Closed
少しマシにした #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resessh
commented
Mar 28, 2019
| @@ -1,4 +1,7 @@ | |||
| self.addEventListener('notificationclick', (event: NotificationEvent) => { | |||
| export declare var self: ServiceWorkerGlobalScope; | |||
There was a problem hiding this comment.
selfが WorkerGlobalScope になってしまうのでうわがく
| /* Basic Options */ | ||
| "target": "esnext", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */ | ||
| "module": "esnext", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | ||
| "lib": ["esnext", "webworker"], /* Specify library files to be included in the compilation. */ |
There was a problem hiding this comment.
"webworker" が "dom" と競合するので tsconfig 自体を分けた
There was a problem hiding this comment.
"webworker" が "dom" と競合する
これ流石におかしいとおもうんだよなー
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cliちょっと整えた
でビルドされる。
別cliプロセスで
とかするとサーバが立つ
sw周りのtypingをマシにした
https://github.com/Microsoft/TypeScript/blob/master/lib/lib.webworker.d.ts
webworkerをlibに入れたselfとかclientsがおかしいので調整した