Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cl with cl-lib for emacs 27 #20

Closed
wants to merge 1 commit into from
Closed

Conversation

takaxp
Copy link

@takaxp takaxp commented Jan 30, 2020

Package cl is deprecated.

Copy link

@technician77 technician77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a programmer, so I might not even comment here, but if you just apply the change to the .el and recompile you get an error about a "first" function not defined. The error causes the compile to fail. If I revert back to cl it compiles without an error.

@half-shell
Copy link

This works for me on GNU Emacs 27.1.
It gets rid of cl package being deprecated, an issue mentioned here and here, with a comment suggesting packages be updated to use cl-lib instead of cl.

@takaxp Is this still alive? Can we merge this or is there another supported repo that I am not aware of?

@takaxp
Copy link
Author

takaxp commented Nov 27, 2020

Package cl is deprecated is still shown even if GNU Emacs 27.1 is used :(

@stephan-cr
Copy link

stephan-cr commented Dec 17, 2020

As @technician77 correctly points out, there's more work to do. All cl functions/macros have the cl- prefix in cl-lib. first needs to be cl-first. The same applies for second, third and probably many more. Right now it seems to work, because something else is loading cl.

The following functions need a prefix:

  • assert
  • first
  • second
  • third
  • pushnew

Furthermore, lexical-let needs to be replaced by something else.

@pataquets
Copy link

Looks like this PR is superceded by #22. If there's nothing else here, @takaxp: fancy to close this in favor of #22?

@takaxp takaxp closed this Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants