add some value types #129
Merged
add some value types #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2021 15:48
k0kubun
reviewed
Jun 30, 2021
Comment on lines
+28
to
+37
| v_integer integer NOT NULL, | ||
| v_text text, | ||
| v_smallmoney smallmoney, | ||
| v_money money, | ||
| v_datetimeoffset datetimeoffset(1), | ||
| v_datetime2 datetime2, | ||
| v_smalldatetime smalldatetime, | ||
| v_nchar nchar(30), | ||
| v_nvarchar nvarchar(30), | ||
| v_ntext ntext |
There was a problem hiding this comment.
As you can see in this diff on GitHub, the indentation is inconsistent. Please consider checking your code before submitting a PR next time.
Suggested change
| v_integer integer NOT NULL, | |
| v_text text, | |
| v_smallmoney smallmoney, | |
| v_money money, | |
| v_datetimeoffset datetimeoffset(1), | |
| v_datetime2 datetime2, | |
| v_smalldatetime smalldatetime, | |
| v_nchar nchar(30), | |
| v_nvarchar nvarchar(30), | |
| v_ntext ntext | |
| v_integer integer NOT NULL, | |
| v_text text, | |
| v_smallmoney smallmoney, | |
| v_money money, | |
| v_datetimeoffset datetimeoffset(1), | |
| v_datetime2 datetime2, | |
| v_smalldatetime smalldatetime, | |
| v_nchar nchar(30), | |
| v_nvarchar nvarchar(30), | |
| v_ntext ntext |
There was a problem hiding this comment.
Sorry for my carelessness, I'll be careful next time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extended the syntax to parse the following data types.