Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some value types #129

Merged
merged 2 commits into from
Jun 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions cmd/mssqldef/mssqldef_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,17 @@ func TestMssqldefColumnLiteral(t *testing.T) {
resetTestDatabase()

createTable := stripHeredoc(`
CREATE TABLE users (
id integer NOT NULL,
name text,
age integer
CREATE TABLE v (
v_integer integer NOT NULL,
v_text text,
v_smallmoney smallmoney,
v_money money,
v_datetimeoffset datetimeoffset(1),
v_datetime2 datetime2,
v_smalldatetime smalldatetime,
v_nchar nchar(30),
v_nvarchar nvarchar(30),
v_ntext ntext
Comment on lines +28 to +37
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see in this diff on GitHub, the indentation is inconsistent. Please consider checking your code before submitting a PR next time.

Suggested change
v_integer integer NOT NULL,
v_text text,
v_smallmoney smallmoney,
v_money money,
v_datetimeoffset datetimeoffset(1),
v_datetime2 datetime2,
v_smalldatetime smalldatetime,
v_nchar nchar(30),
v_nvarchar nvarchar(30),
v_ntext ntext
v_integer integer NOT NULL,
v_text text,
v_smallmoney smallmoney,
v_money money,
v_datetimeoffset datetimeoffset(1),
v_datetime2 datetime2,
v_smalldatetime smalldatetime,
v_nchar nchar(30),
v_nvarchar nvarchar(30),
v_ntext ntext

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my carelessness, I'll be careful next time.

);
`,
)
Expand Down
Loading