Make error outputs more detail to show pg_dump errors #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
reviewed
Aug 15, 2019
adapter/postgres/postgres.go
Outdated
| if err != nil { | ||
| return "", err | ||
| return "", fmt.Errorf("%s :\n\n %s\n", err, out) |
There was a problem hiding this comment.
What do you think about:
Suggested change
| return "", fmt.Errorf("%s :\n\n %s\n", err, out) | |
| return "", fmt.Errorf("%s :\n\n%s\n", err, out) |
When out is multi-line, I think it's more natural:
2019/08/14 17:28:33 Error on DumpDDLs: exit status 1 :
pg_dump: server version: 10.1; pg_dump version: 9.6.15
pg_dump: aborting because of server version mismatch
There was a problem hiding this comment.
It seems better!
Thank you!
sonken625
commented
Aug 15, 2019
There was a problem hiding this comment.
What do you think about?
I am stating to think that it doesn't need two new line code.
before
2019/08/15 01:37:22 Error on DumpDDLs: exit status 1 :
pg_dump: server version: 10.1; pg_dump version: 9.6.15
pg_dump: aborting because of server version mismatch
after
2019/08/15 01:37:22 Error on DumpDDLs: exit status 1 :
pg_dump: server version: 10.1; pg_dump version: 9.6.15
pg_dump: aborting because of server version mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29
before
after