Skip to content

Make error outputs more detail to show pg_dump errors #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2019
Merged

Make error outputs more detail to show pg_dump errors #30

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fe452d
Make error outputs more detail to show pg_dump errors
sonken625 Aug 14, 2019
2e412da
Merge branch 'master' into feature/make_errors_more_detail
k0kubun Aug 15, 2019
59b39e6
Modify error messages style
sonken625 Aug 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions adapter/postgres/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,9 @@ func runPgDump(config adapter.Config, table string) (string, error) {
cmd.Env = append(cmd.Env, fmt.Sprintf("PGPASSWORD=%s", config.Password)) // XXX: Can we pass this in DSN format in a safe way?
}

out, err := cmd.Output()
out, err := cmd.CombinedOutput()
if err != nil {
return "", err
return "", fmt.Errorf("%s :\n%s\n", err, out)
}

return string(out), nil
Expand Down