Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

Found a few bugs and feedback #19

Closed
wasdennnoch opened this issue Feb 26, 2017 · 11 comments
Closed

Found a few bugs and feedback #19

wasdennnoch opened this issue Feb 26, 2017 · 11 comments

Comments

@wasdennnoch
Copy link

In 2 minutes of usage I already found 3 bugs. Yay!

I screenshotted them in this album, unfortunately the order is reversed and I can't change it on mobile: http://imgur.com/a/icKeH

  1. The app icon in the splash screen is stretched beyond the top
  2. "In 24 Minutes" (What does that time even mean?)
  3. Double loading indicators in all swipe-to-refresh views

Additionally I found that when deleting a gist the gist list doesn't get refreshed and still shows the one you just deleted.
The preview button in the markdown editor has an empty tooltip.

Moving over to the general feedback:

One thing I immediately noticed is that everything is monospace which looks really ugly. In the Reddit thread you said it should be Roboto iirc, but if so it's not.
Then you could replace the toolbar icons in the markdown editing screen I'm in right now with icons.
You could also include a little tutorial which explains where which thing is and how others work. I just noticed that you can actually scroll the lower markdown tobar to get image shortcuts and such.

I'll update this list if I find any more stuff.

@wasdennnoch
Copy link
Author

Another thing: I can't edit the issue.

And it shows "in 1 hour" as the creation time, it should take into account the timezone.

@wasdennnoch
Copy link
Author

I can't edit anything yet, so I guess it'll be implemented soon.
I can still "manage" the tags for this issue although I'm not permitted to (gives a 403).

@k0shk0sh
Copy link
Owner

k0shk0sh commented Feb 27, 2017

@wasdennnoch Thanks for your feedback. i really loved your detailed explanation plus the screenshot. I will be working on fixing/adding these stuff and let you know about the process.

You could edit your comments tho, Editing Issues & PullRequests should be soon as mentioned in #21

thanks again.

@k0shk0sh
Copy link
Owner

In (time) is actually when the repo last updated, I have did some guides yesterday and still doing throughout the app. next version will have them.

@k0shk0sh k0shk0sh added this to the 1.0.4 milestone Feb 27, 2017
k0shk0sh pushed a commit that referenced this issue Feb 27, 2017
… on larger screens, added last updated label to make sense of the update date showing, fixed Issue labeling where only the repo owner could label an issue. fixing some of what reported in #19, made NavigationView consume clicks to prevent touching behind it closing #18
k0shk0sh pushed a commit that referenced this issue Feb 27, 2017
…19, removed handling view stuff from presenters in comments presenter.
@k0shk0sh k0shk0sh modified the milestones: 1.0.5, 1.0.4 Feb 27, 2017
@k0shk0sh
Copy link
Owner

Some of above, are fixed. please do check the last version of FastHub when you get an update.
I'll keep this open until i fix or add the other things.

@wasdennnoch
Copy link
Author

wasdennnoch commented Feb 27, 2017

The splash screen, label management, app font and tutorials seem to be fixed now. I noticed some other things though:

In the "you have notifications" dialog clicking either the button or the layout does nothing other than collapsing the status bar.

It looks like the file titles in a commit view are fixed to 2 rows without ellipsizing (however that's spelled).

The text "No newline at end of file" could be replaced with an icon like on the Github website.

It would be handy if a click on the follower/ing count in the profile directly takes you to the corresponding tab.

Maybe the wrong timestamps are related to my device language being set to EN/US while I'm living in DE, I'll try changing it.

EDIT: Nope, even when changing the language it stays the same.

@k0shk0sh
Copy link
Owner

I'm driving right now, but gonna keep this here to not forget it, I think I know why the date is wrong is due to the rawOffset I'm adding to the UTC time, while your time is UTC. I will comment later on the others as i need some more info.
thanks

@k0shk0sh
Copy link
Owner

k0shk0sh commented Feb 27, 2017

@wasdennnoch thanks again for your feedback. I'm abit lost to be honest, I really appreciate your feedbacks and love to have more from you, however I wanna ask you for a favor, could you separate these bugs, enhancement & features in separate issue tickets so I can keep track of them & have them organized to easily close each one of them.

again, Thank you very much.

@wasdennnoch
Copy link
Author

Can do that.

@k0shk0sh
Copy link
Owner

great mate, I really do appreciate your efforts in helping FastHub and specifically me.
Thanks

@wasdennnoch
Copy link
Author

I think I got all of them separated now, will close this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants