Skip to content

Commit

Permalink
chore: keep unpinning images in case of failure
Browse files Browse the repository at this point in the history
if we fail to unpin one image we can keep moving and unpining the
others.

Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
  • Loading branch information
ricardomaraschini committed Jul 8, 2024
1 parent 612d561 commit fbe8692
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/component/worker/ocibundle.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ func (a *OCIBundleReconciler) unpinAll(ctx context.Context) error {

for _, image := range images {
if err := a.unpinOne(ctx, image, isvc); err != nil {
return fmt.Errorf("failed to unpin %s: %w", image.Name, err)
a.log.WithError(err).Errorf("Failed to unpin image %s", image.Name)
}
}
return nil
Expand Down

0 comments on commit fbe8692

Please sign in to comment.