Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize component model #4357

Open
jnummelin opened this issue May 2, 2024 · 9 comments
Open

Sanitize component model #4357

jnummelin opened this issue May 2, 2024 · 9 comments
Labels
chore

Comments

@jnummelin
Copy link
Member

From @twz123 in #4213 (comment)

I still think we should eventually sanitize our component model. Either use the context from Start and don't have a Stop method, or only use the Stop method to stop the component, disregarding the context from Start. There's just no sense in having a Stop method if it's a no-op even for components that are actually running and need to be stopped.

We would need to break up the component interface a bit and go through all the components to use the root context properly.
@jnummelin jnummelin added the chore label May 2, 2024
@twz123
Copy link
Member

twz123 commented May 2, 2024

/xref #1844

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 1, 2024

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Jun 1, 2024
@twz123 twz123 removed the Stale label Jun 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Jul 2, 2024
@twz123 twz123 removed the Stale label Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Aug 2, 2024
@twz123 twz123 removed the Stale label Aug 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Sep 2, 2024
@twz123 twz123 removed the Stale label Sep 4, 2024
@twz123 twz123 mentioned this issue Sep 4, 2024
Merged
16 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Oct 4, 2024
@twz123 twz123 removed the Stale label Oct 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Nov 6, 2024
@twz123 twz123 removed the Stale label Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Dec 11, 2024
@twz123 twz123 removed the Stale label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Jan 11, 2025
@twz123 twz123 removed the Stale label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@twz123 @jnummelin