Don't store contexts in lease pool structs #4733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This revealed and depends on #4744. |
|
This pull request has merge conflicts that need to be resolved. |
The context shouldn't be stored in structs, but passed as the first argument to functions and methods. Remove the context storage from the lease pool and pass it to the methods where it's actually needed. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
| if err != nil { | ||
| return err | ||
| } | ||
| events, cancel, err := leasePool.Watch() | ||
|
|
||
| ctx, cancel := context.WithCancel(context.Background()) |
There was a problem hiding this comment.
I don't understand this change.
Why shouldn't the context.WithCancel be based on the one Startgets as an argument? If that context is Done I think this should be done too.
There was a problem hiding this comment.
This is one of the big issues that exists with the component model in k0s. See #4357 and its predecessor #1844.
So from my point of view, the context passed to Start should be used to cancel any async/blocking operations that are performed during startup. Any asynchronous operations that happen as a result of the component being started should be handled by Stop.
| if err != nil { | ||
| return err | ||
| } | ||
| events, cancel, err := leasePool.Watch() | ||
| ctx, cancel := context.WithCancel(context.Background()) |
16 tasks
16 tasks
juanluisvaladas
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The context shouldn't be stored in structs, but passed as the first argument to functions and methods. Remove the context storage from the lease pool and pass it to the methods where it's actually needed.
See:
Type of change
How Has This Been Tested?
Checklist: