Add controller lease counter component after API server #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
jnummelin
reviewed
Jul 12, 2024
|
This pull request has merge conflicts that need to be resolved. |
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Move server count and cluster config into the reconciliation goroutine and pass them as args to the write method. This will limit their scope and prevent them from being inadvertently updated by other goroutines. Remove the mutex, since the write method is only called by a single goroutine. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
The controller lease counter requires the API server to be up and running in order to work properly. It cannot acquire or count leases before the API server is up, nor can it release the lease after the API server is shut down. Move the counter component down in the controller start method, so that it's started after the API server. Decouple the actual controller count value from the counter component by putting it directly into the start method. Let the counter component update that value, and let the konnectivity components consume those updates. Introduce internal/sync.Latest as a small abstraction for values that may change over time and will be consumed by multiple observers. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
twz123
force-pushed
the
apisever-before-leasecounter
branch
from
bbe0301 to
3a6b68b
Compare
jnummelin
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The controller lease counter requires the API server to be up and running in order to work properly. It cannot acquire or count leases before the API server is up, nor can it release the lease after the API server is shut down.
Move the counter component down in the controller start method, so that it's started after the API server. Decouple the actual controller count value from the counter component by putting it directly into the start method. Let the counter component update that value, and let the konnectivity components consume those updates.
Introduce
internal/sync.Latestas a small abstraction for values that may change over time and will be consumed by multiple observers.Type of change
How Has This Been Tested?
Checklist: