Cleanup backup restore and document external deps #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncopa
force-pushed
the
cleanup-backup-restore
branch
4 times, most recently
from
b9f2ccd to
ed48d89
Compare
ncopa
force-pushed
the
cleanup-backup-restore
branch
from
dc4e76a to
099a1d1
Compare
ncopa
force-pushed
the
cleanup-backup-restore
branch
from
099a1d1 to
e662472
Compare
Signed-off-by: Natanael Copa <ncopa@mirantis.com>
Verify that filesystem's Backup() creates the list as expected when: - the path is a directory with files - the path is a single file - the path points to something non-existing Signed-off-by: Natanael Copa <ncopa@mirantis.com>
Remove unnecessary dir() helper function. The filepath.Walk() will walk the top-level path if it is a file, so we don't need to test for IsDir(). We can catch the IsNotExist error while walking the path. Signed-off-by: Natanael Copa <ncopa@mirantis.com>
Signed-off-by: Natanael Copa <ncopa@mirantis.com>
Signed-off-by: Natanael Copa <ncopa@mirantis.com>
ref k0sproject#2473 (comment) Signed-off-by: Natanael Copa <ncopa@mirantis.com>
fixes k0sproject#2473 Signed-off-by: Natanael Copa <ncopa@mirantis.com>
ncopa
force-pushed
the
cleanup-backup-restore
branch
from
e662472 to
bf66960
Compare
juanluisvaladas
approved these changes
Apr 5, 2023
kke
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2473
Type of change
How Has This Been Tested?
Checklist: