Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use atomic.Bool instead of atomic.Value for leader status #4461

Merged
merged 1 commit into from
May 22, 2024
Merged

Use atomic.Bool instead of atomic.Value for leader status #4461

merged 1 commit into from
May 22, 2024

Conversation

kke
Copy link
Contributor

@kke kke commented May 22, 2024

Description

Lease pool's leader status field was an atomic.Value that is always used for booleans only. This requires pre-initializing it through Store(false) and also typecasting when retrieving.

By using atomic.Bool, the zero value is false and the value type is always bool.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@kke kke added the chore label May 22, 2024
@kke kke requested a review from a team as a code owner May 22, 2024 07:07
@kke kke requested review from jnummelin and juanluisvaladas May 22, 2024 07:07
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@kke
Use atomic.Bool instead of atomic.Value for leader status
6282754 
Lease pool's leader status field was an atomic.Value that is always used
for booleans only. This requires pre-initializing it through
Store(false) and also typecasting when retrieving.

By using atomic.Bool, the zero value is false and the value type is
always bool.

Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke force-pushed the leaderstatus-bool branch from f6e74fc to 6282754 Compare May 22, 2024 07:38
@kke kke merged commit 9ea00c6 into main May 22, 2024
77 of 78 checks passed
@kke kke deleted the leaderstatus-bool branch May 22, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas juanluisvaladas is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kke @jnummelin