Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused atomic.Value from CSRApprover constructor #4462

Merged
merged 1 commit into from
May 22, 2024

Conversation

kke
Copy link
Contributor

@kke kke commented May 22, 2024

Description

There was some leftover atomic.Value initialization in the CSRApprover's constructor. The value was initialized but was never used.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

There was some leftover atomic.Value initialization in the CSRApprover's
constructor. The value was initialized but was never used.

Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke added the chore label May 22, 2024
@kke kke requested a review from a team as a code owner May 22, 2024 07:10
@kke kke requested review from ncopa and makhov May 22, 2024 07:10
@kke kke changed the title Remove unused atomic.Value from csrapprover constructor Remove unused atomic.Value from CSRApprover constructor May 22, 2024
@kke kke merged commit 48c87be into main May 22, 2024
77 of 78 checks passed
@kke kke deleted the unused-atomic-value branch May 22, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants