-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip kube-bridge
interface for api/etcd address
#4467
Merged
twz123
merged 1 commit into
k0sproject:main
from
jnummelin:fix/skip-cni-addresses-for-config-defaulting
May 22, 2024
Merged
Skip kube-bridge
interface for api/etcd address
#4467
twz123
merged 1 commit into
k0sproject:main
from
jnummelin:fix/skip-cni-addresses-for-config-defaulting
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnummelin
added
bug
Something isn't working
area/controlplane
area/configuration
backport/release-1.27
PR that needs to be backported/cherrypicked to release-1.27 branch
backport/release-1.28
PR that needs to be backported/cherrypicked to release-1.28 branch
backport/release-1.29
PR that needs to be backported/cherrypicked to the release-1.29 branch
backport/release-1.30
PR that needs to be backported/cherrypicked to the release-1.30 branch
labels
May 22, 2024
jnummelin
force-pushed
the
fix/skip-cni-addresses-for-config-defaulting
branch
from
May 22, 2024 11:00
1e69887
to
76e1946
Compare
Otherwise the defaulting could pick up `kube-bridge` address as api/etcd address when restarting k0s if it sees it before any "real" address. This happens on e.g. bootloose containers where kube-bridge is at index 11 and eth0 on index 18. Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
jnummelin
force-pushed
the
fix/skip-cni-addresses-for-config-defaulting
branch
from
May 22, 2024 13:49
76e1946
to
dd2fdca
Compare
twz123
approved these changes
May 22, 2024
Successfully created backport PR for |
Successfully created backport PR for |
Successfully created backport PR for |
This was referenced May 22, 2024
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/configuration
area/controlplane
backport/release-1.27
PR that needs to be backported/cherrypicked to release-1.27 branch
backport/release-1.28
PR that needs to be backported/cherrypicked to release-1.28 branch
backport/release-1.29
PR that needs to be backported/cherrypicked to the release-1.29 branch
backport/release-1.30
PR that needs to be backported/cherrypicked to the release-1.30 branch
bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Otherwise the defaulting could pick up
kube-bridge
address as api/etcd address when restarting k0s if it sees it before any "real" address.This happens on e.g. bootloose containers where kube-bridge is at index 11 and eth0 on index 18.
Type of change
How Has This Been Tested?
Checklist: