Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip kube-bridge interface for api/etcd address #4467

Merged

Conversation

jnummelin
Copy link
Member

Description

Otherwise the defaulting could pick up kube-bridge address as api/etcd address when restarting k0s if it sees it before any "real" address.

This happens on e.g. bootloose containers where kube-bridge is at index 11 and eth0 on index 18.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jnummelin jnummelin requested a review from a team as a code owner May 22, 2024 10:59
@jnummelin jnummelin requested review from ncopa and makhov May 22, 2024 10:59
@jnummelin jnummelin added bug Something isn't working area/controlplane area/configuration backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch labels May 22, 2024
@jnummelin jnummelin force-pushed the fix/skip-cni-addresses-for-config-defaulting branch from 1e69887 to 76e1946 Compare May 22, 2024 11:00
Otherwise the defaulting could pick up `kube-bridge` address as api/etcd address when restarting k0s if it sees it before any "real" address.

This happens on e.g. bootloose containers where kube-bridge is at index 11 and eth0 on index 18.

Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
@jnummelin jnummelin force-pushed the fix/skip-cni-addresses-for-config-defaulting branch from 76e1946 to dd2fdca Compare May 22, 2024 13:49
@twz123 twz123 merged commit 488d38e into k0sproject:main May 22, 2024
78 checks passed
@k0s-bot
Copy link

k0s-bot commented May 22, 2024

Successfully created backport PR for release-1.27:

@k0s-bot
Copy link

k0s-bot commented May 22, 2024

Successfully created backport PR for release-1.28:

@k0s-bot
Copy link

k0s-bot commented May 22, 2024

Successfully created backport PR for release-1.29:

@k0s-bot
Copy link

k0s-bot commented May 22, 2024

Successfully created backport PR for release-1.30:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration area/controlplane backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants