Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also add kube-proxy mode to uploaded artifact names #4652

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 18, 2024

Description

This allows for running the e2e test matrix for multiple kube-proxy modes at the same time. Otherwise, some uploads would fail due to duplicate artifact names.

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

This allows for running the e2e test matrix for multiple kube-proxy
modes at the same time. Otherwise, some uploads would fail due to
duplicate artifact names.

Fixes: 64a442d ("Add new dimension for kube-proxy mode to OS testing matrix")
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added bug Something isn't working area/ci labels Jun 18, 2024
@twz123 twz123 marked this pull request as ready for review June 18, 2024 10:00
@twz123 twz123 requested a review from a team as a code owner June 18, 2024 10:00
@twz123 twz123 requested review from kke and makhov June 18, 2024 10:00
@twz123 twz123 merged commit 4d0e2ef into k0sproject:main Jun 25, 2024
81 checks passed
@twz123 twz123 deleted the fix-ostests-e2e-upload branch June 25, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants