Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable and document the insecure field for Helm Repos #4660

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Enable and document the insecure field for Helm Repos #4660

merged 2 commits into from
Jun 25, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 19, 2024 •
edited
Loading

Description

The insecure field exists in the CRD for a long time already. Wire it up, so it can actually be used to enable TLS certificate checks.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

twz123 added 2 commits June 19, 2024 17:34
@twz123
Add docs for Helm Repositories in k0s config
9965d04 
Also mark required fields as such and make the rest optional.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123
Enable and document the insecure field for Helm Repos
b6afccf 
The insecure field exists in the CRD for a long time already. Wire it
up, so it can actually be used to enable TLS certificate checks.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 marked this pull request as ready for review June 19, 2024 17:05
@twz123 twz123 requested a review from a team as a code owner June 19, 2024 17:05
@twz123 twz123 requested review from ncopa and jnummelin June 19, 2024 17:05
@twz123 twz123 merged commit a9d24db into k0sproject:main Jun 25, 2024
84 checks passed
@twz123 twz123 deleted the helm-insecure branch June 25, 2024 10:37
@twz123 twz123 added the backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch label Jun 25, 2024
@k0s-bot k0s-bot mentioned this pull request Jun 25, 2024
Merged
@k0s-bot
Copy link

k0s-bot commented Jun 25, 2024

Successfully created backport PR for release-1.30:

@twz123 twz123 mentioned this pull request Jul 12, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncopa ncopa ncopa approved these changes

@jnummelin jnummelin Awaiting requested review from jnummelin jnummelin is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/configuration area/helm backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twz123 @k0s-bot @ncopa