Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize k0s config create code and docs #4673

Closed
wants to merge 1 commit into from
Closed

Synchronize k0s config create code and docs #4673

wants to merge 1 commit into from

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 25, 2024

Description

Convert the config to unstructured to be able to tweak the actual YAML. Remove the creationTimestamp from the output. Remove the omitempty flag from the NLLB enabled field, so that it's false value makes it into the output. Remove all the parts from the docs that don't show up in reality.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Synchronize k0s config create code and docs
9b785a1 
Convert the config to unstructured to be able to tweak the actual YAML.
Remove the creationTimestamp from the output. Remove the omitempty
flag from the NLLB enabled field, so that it's false value makes it
into the output. Remove all the parts from the docs that don't show up
in reality.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added documentation Improvements or additions to documentation chore area/cli labels Jun 25, 2024
@twz123 twz123 marked this pull request as ready for review June 25, 2024 17:26
@twz123 twz123 requested a review from a team as a code owner June 25, 2024 17:26
@twz123 twz123 requested review from ncopa and kke June 25, 2024 17:26
@twz123
Copy link
Member Author

twz123 commented Jun 26, 2024

Closed in favor of #4674.

@twz123 twz123 closed this Jun 26, 2024
@twz123 twz123 deleted the config-create-creation-ts branch June 26, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/cli chore documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twz123