Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract smoketests job into its own file #4678

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 27, 2024

Description

This allows for integrating the smoke tests and autopilot tests into a single job template. Downloading the k0s release was the only difference. Add an optional input for that.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 force-pushed the extract-smoketests branch 2 times, most recently from 271b432 to 80ab0e1 Compare June 27, 2024 10:48
@twz123 twz123 marked this pull request as ready for review June 27, 2024 11:07
@twz123 twz123 requested a review from a team as a code owner June 27, 2024 11:07
@twz123 twz123 requested review from kke and juanluisvaladas June 27, 2024 11:07
jnummelin
jnummelin previously approved these changes Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

This pull request has merge conflicts that need to be resolved.

Copy link
Contributor

github-actions bot commented Jul 5, 2024

This pull request has merge conflicts that need to be resolved.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

This pull request has merge conflicts that need to be resolved.

twz123 added 4 commits July 9, 2024 10:07
This allows for reusability.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
This makes the names look more concise when looking at workflow runs.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Downloading the k0s release was the only difference. Add an optional
input for that. Make the job name configurable, too. This is mainly used
to distinguish potential artifact uploads between the ap-ha3x3 smoke
test and the Autopilot upgrate checks.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 merged commit 9bd6b8b into k0sproject:main Jul 12, 2024
82 checks passed
@twz123 twz123 deleted the extract-smoketests branch July 12, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants