-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract smoketests job into its own file #4678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
force-pushed
the
extract-smoketests
branch
2 times, most recently
from
June 27, 2024 10:48
271b432
to
80ab0e1
Compare
jnummelin
previously approved these changes
Jul 3, 2024
This pull request has merge conflicts that need to be resolved. |
twz123
force-pushed
the
extract-smoketests
branch
from
July 3, 2024 15:38
80ab0e1
to
1e6d2cd
Compare
This pull request has merge conflicts that need to be resolved. |
twz123
force-pushed
the
extract-smoketests
branch
from
July 5, 2024 15:43
1e6d2cd
to
f5588ec
Compare
This pull request has merge conflicts that need to be resolved. |
This allows for reusability. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
This makes the names look more concise when looking at workflow runs. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Downloading the k0s release was the only difference. Add an optional input for that. Make the job name configurable, too. This is mainly used to distinguish potential artifact uploads between the ap-ha3x3 smoke test and the Autopilot upgrate checks. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
twz123
force-pushed
the
extract-smoketests
branch
from
July 9, 2024 08:10
f5588ec
to
46c2ad4
Compare
jnummelin
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows for integrating the smoke tests and autopilot tests into a single job template. Downloading the k0s release was the only difference. Add an optional input for that.
Type of change
How Has This Been Tested?
Checklist: