Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some context fields from some structs #4746

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jul 10, 2024

Description

Do it the idiomatic way instead, by passing the context around as the first parameter.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Do it the idiomatic way instead, by passing the context around as the
first parameter.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added the chore label Jul 10, 2024
@twz123 twz123 marked this pull request as ready for review July 10, 2024 17:25
@twz123 twz123 requested a review from a team as a code owner July 10, 2024 17:25
@twz123 twz123 requested review from ncopa and makhov July 10, 2024 17:25
@twz123 twz123 merged commit 1e4cf2b into k0sproject:main Jul 12, 2024
83 checks passed
@twz123 twz123 deleted the less-contexts-in-structs branch July 12, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants