Separate the initialization and reconciliation in ClusterConfigReconciler #4747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
This is something that's separate from the cluster config reconciliation, hence start to decouple them. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
It's more straight forward to move the CRD application into the if branch that configures dynamic configuration instead of relying on the ConfigSource method. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
This allows for the removal of the initializer-only dependencies from the reconciler. Adding the initializer only if dynamic config is enabled allows the NeedToStoreInitialConfig method to be removed from the config sources. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
The Reconcile method is all that's needed, so no need to force a specific implementation. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
jnummelin
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The cluster config initialization and the reconciliation are two independent things. The
ClusterConfigReconcilerdid both of them at the same time. By separating the initialization part into theClusterConfigInitializer, there's a clearer separation of concerns, and no longer the need to have aNeedToStoreInitialConfigmethod on config sources.Type of change
How Has This Been Tested?
Checklist: