[Backport release-1.28] Cleanup unknown Helm chart manifest files #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s scheme" This reverts commit 961f303.
This is an internal implementation detail of the extensions controller and not an inherent property of the chart resource. Hence move the func into the controller and make it private. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com> (cherry picked from commit 394418d) (cherry picked from commit 966dc5e) (cherry picked from commit 0cbc962)
Keep track of the generated filenames when reconciling Helm Chart extensions. After all files have been synchronized, remove any remaining unknown Helm chart manifest files. This way the synchronization will work correctly even if the Helm chart extension names and orders are changed. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com> (cherry picked from commit c1f8c75) (cherry picked from commit 0e4db6a) (cherry picked from commit bfaff3b)
twz123
added
bug
ncopa
approved these changes
Jul 17, 2024
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.27
git worktree add -d .worktree/backport-4762-to-release-1.27 origin/release-1.27
cd .worktree/backport-4762-to-release-1.27
git checkout -b backport-4762-to-release-1.27
ancref=$(git merge-base ea9eb8e776a793f3875d04a20fe3839e1229816d 6dc0306d495fd5095b41469d8d1034a44922229e)
git cherry-pick -x $ancref..6dc0306d495fd5095b41469d8d1034a44922229e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to
release-1.28:As #4635 was necessary for this backport, this PR also reverts 961f303, which was a replacement for #4635 when backporting #4585 in #4601.
See: