bug: add support for image tag and digest

[emosbaugh]

Description

When adding an envoy image with tag and digest I get a failure:

invalid node config: spec: network: nodeLocalLoadBalancing.envoyProxy.image.version: Invalid value: "1.29.5-r0@sha256:7856e4d51f6631b1121c79ec93958897f1d90a52ce8d1d3513cff73df6821a2b": must match regular expression: ^[\w][\w.-]{0,127}$

This change adds support for an optional digested image reference.

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

How Has This Been Tested?

• Manual test
• Auto test added

Checklist:

• My code follows the style guidelines of this project
• My commit messages are signed-off
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

[twz123]

Darn! That was definitely an oversight. Surprising that there's no ready-made constant for this in github.com/distribution/reference. I wonder if it makes sense to simply use a single string instead of the image/version struct in a potential config version v2. This is how it's done in upstream Kubernetes anyways. Then we could use github.com/distribution/reference.ReferenceRegexp.

Fixes #2428.

[twz123]

Thanks a lot!

[k0s-bot]

Backport failed for release-1.30, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.30
git worktree add -d .worktree/backport-4792-to-release-1.30 origin/release-1.30
cd .worktree/backport-4792-to-release-1.30
git switch --create backport-4792-to-release-1.30
git cherry-pick -x f7f641b7360a66682d202a86ef65780a9725a23d

[sgalsaleh]

Is it possible to backport this fix to 1.28 as well?

[twz123]

Is it possible to backport this fix to 1.28 as well?

This is going into all supported releases, i.e. down to 1.27.

[emosbaugh]

@twz123 I wanted to call out that ClusterImages.Validate does not call ImageSpec.Validate. Validate is only called for the envoy image. I unintentionally pushed this test which would have failed had it been called. Is there any follow up action you would like me to take here like to remove the test? Thanks for the quick turnaround!

[twz123]

I wanted to call out that ClusterImages.Validate does not call ImageSpec.Validate.

That explains why this didn't crop up earlier.

Is there any follow up action you would like me to take here like to remove the test?

Actually validating the images in ClusterImages.Validate seems reasonable to me. PRs are welcome, as always 🙃