Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix url.parse error #4868

Closed
wants to merge 1 commit into from
Closed

fix url.parse error #4868

wants to merge 1 commit into from

Conversation

fruworg
Copy link

@fruworg fruworg commented Aug 16, 2024

Description

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual test

This is just an example of problem solving for #4867.

@fruworg
fix url.parse error
650d57c 
Signed-off-by: ruslan <im@fruw.org>
@fruworg fruworg requested a review from a team as a code owner August 16, 2024 20:55
@fruworg fruworg requested review from kke and juanluisvaladas August 16, 2024 20:55
@fruworg fruworg mentioned this pull request Aug 16, 2024
Closed
4 tasks
@juanluisvaladas juanluisvaladas added backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch labels Aug 20, 2024
@juanluisvaladas
Copy link
Contributor

Hi @fruworg, thanks for the contribution. I'll wait for the tests to pass and if everything is OK I'll approve.

For the record: url.Parse parses URLs, DSNs aren't necessarily legal URLs: golang/go#12200

juanluisvaladas
juanluisvaladas requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@juanluisvaladas juanluisvaladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter fails becuase gofmt. Most certainly can be fixed by runninggofmt -s -w <file>

@twz123 twz123 mentioned this pull request Aug 21, 2024
Merged
16 tasks
@fruworg
Copy link
Author

fruworg commented Aug 22, 2024

Hi, I think the fix in #4879 is a better solution.

@fruworg fruworg closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanluisvaladas juanluisvaladas juanluisvaladas requested changes

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruworg @juanluisvaladas