Replace go-bindata with go:embed #4895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that need to be resolved. |
kke
reviewed
Aug 27, 2024
twz123
force-pushed
the
replace-go-bindata
branch
from
1166bb6 to
648a072
Compare
16 tasks
twz123
force-pushed
the
replace-go-bindata
branch
from
648a072 to
2dd99d6
Compare
|
This pull request has merge conflicts that need to be resolved. |
twz123
force-pushed
the
replace-go-bindata
branch
from
2dd99d6 to
79685e6
Compare
Start and Stop are no-ops, so this was not checking anything of interest anymore. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Use Go's built-in way of embedding static assets in binaries, instead of relying on the somewhat legacy go-bindata tool. This allows the embedding to be handled transparently by the Go compiler, eliminating some extra Makefile steps. Hide the path prefixes used to embed the data behind a sub-fs. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
twz123
force-pushed
the
replace-go-bindata
branch
from
79685e6 to
80c599c
Compare
jnummelin
approved these changes
Sep 6, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Go's built-in way of embedding static assets in binaries, instead of relying on the somewhat legacy go-bindata tool. This allows the embedding to be handled transparently by the Go compiler, eliminating some extra Makefile steps.
Hide the path prefixes used to embed the data behind a sub-fs.
Type of change
How Has This Been Tested?
Checklist: