Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd join workflow fix when the first attempt fails #4900

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

makhov
Copy link
Contributor

@makhov makhov commented Aug 27, 2024

Description

Currently, if the first attempt to join etcd cluster fails (e.g. /v1beta1/etcd/members request returned 500), k0s won't try to join etcd again, because needToJoin() function only checks for the existence of the certificates.

This causes issues for k0smotron, where we spin up new machines in unpredictable order

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@makhov makhov added the bug Something isn't working label Aug 27, 2024
Signed-off-by: Alexey Makhov <amakhov@mirantis.com>
@makhov makhov marked this pull request as ready for review August 28, 2024 09:21
@makhov makhov requested a review from a team as a code owner August 28, 2024 09:21
@makhov makhov requested review from kke and juanluisvaladas August 28, 2024 09:21
@makhov makhov added backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch labels Aug 29, 2024
Copy link
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it's worth to add retries for 5xx errors to the etcd join process itself, too.

@makhov makhov merged commit 0b39082 into k0sproject:main Aug 29, 2024
83 checks passed
@k0s-bot
Copy link

k0s-bot commented Aug 29, 2024

Successfully created backport PR for release-1.28:

@k0s-bot
Copy link

k0s-bot commented Aug 29, 2024

Successfully created backport PR for release-1.29:

@k0s-bot
Copy link

k0s-bot commented Aug 29, 2024

Successfully created backport PR for release-1.30:

@makhov
Copy link
Contributor Author

makhov commented Aug 29, 2024

There are some retries, but they are too fast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants